Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-5733

URIBuilder causes warnings for resources from jar with "!" in url

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 10.0.1
    • 10.0.1, FL
    • None
    • Security Level: Jimmy
    • None
    • None

      Steps to Reproduce

      Load a zul page (minimal page below).
      On a restarted server.
      Force cache break (ctrl+f5) at client.

      	<div>
      		<button/>
      	</div>
      

      Current Result

      Every resource loaded from jar by org.zkoss.zk.ui.http.AbstractExtendlet.getResourceAsStream
      throws a malformed URL exception

      15:04:42.414 [qtp1795799895-36] WARN org.zkoss.zk.ui.http.AbstractExtendlet -- Unable to read from URL: /js/zkmax/index.src.js
      java.net.MalformedURLException: no !/ in spec
      	at java.base/java.net.URL.<init>(URL.java:708)
      	at java.base/java.net.URL.fromURI(URL.java:748)
      	at java.base/java.net.URI.toURL(URI.java:1139)
      	at org.zkoss.zk.ui.http.AbstractExtendlet.getResourceAsStream(AbstractExtendlet.java:182)
      	at org.zkoss.zk.ui.http.AbstractExtendlet$RequestContext.getResourceAsStream(AbstractExtendlet.java:223)
      	at org.zkoss.zk.ui.http.WpdExtendlet.findResourcePath(WpdExtendlet.java:586)
      	at org.zkoss.zk.ui.http.WpdExtendlet.writeResource(WpdExtendlet.java:608)
      	at org.zkoss.zk.ui.http.WpdExtendlet.parse(WpdExtendlet.java:456)
      	at org.zkoss.zk.ui.http.WpdExtendlet$SourceInfo.parse(WpdExtendlet.java:859)
      	at org.zkoss.zk.ui.http.WpdExtendlet$Content.parse(WpdExtendlet.java:837)
      	at org.zkoss.zk.ui.http.WpdExtendlet.retrieve(WpdExtendlet.java:220)
      	at org.zkoss.zk.ui.http.WpdExtendlet.mergeJavaScript(WpdExtendlet.java:267)
      	at org.zkoss.zk.ui.http.WpdExtendlet.retrieve(WpdExtendlet.java:236)
      	at org.zkoss.zk.ui.http.WpdExtendlet.service(WpdExtendlet.java:109)
      	at org.zkoss.web.util.resource.ClassWebResource.web0(ClassWebResource.java:599)
      	at org.zkoss.web.util.resource.ClassWebResource.web(ClassWebResource.java:586)
      	at org.zkoss.web.util.resource.ClassWebResource.service(ClassWebResource.java:295)
      	at org.zkoss.zk.au.http.DHtmlResourceServlet.doGet0(DHtmlResourceServlet.java:125)
      	at org.zkoss.zk.au.http.DHtmlUpdateServlet.doGet(DHtmlUpdateServlet.java:343)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
      	at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
      	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
      	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
      	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)
      	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
      	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
      	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)
      	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
      	at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
      	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
      	at org.eclipse.jetty.server.Server.handle(Server.java:516)
      	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)
      	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
      	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
      	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)
      	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
      	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
      	at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)
      	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
      	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
      	at java.base/java.lang.Thread.run(Thread.java:840)
      Caused by: java.lang.NullPointerException: no !/ in spec
      	at java.base/sun.net.www.protocol.jar.Handler.parseAbsoluteSpec(Handler.java:177)
      	at java.base/sun.net.www.protocol.jar.Handler.parseURL(Handler.java:162)
      	at java.base/java.net.URL.<init>(URL.java:703)
      	... 53 common frames omitted
      

      Expected Result

      No exception

      Debug Information

      Urls processed in looks like "jar:file:/C:/Users/USERNAME/.m2/repository/org/zkoss/zk/zkbind/10.0.1.FL.20240605/zkbind-10.0.1.FL.20240605.jar!/web/js/zkbind/index.src.js"

      appear to be caused by
      https://github.com/zkoss/zk/commit/f51152c236ba4e4105f2570be55ecbfe617546fc#diff-54c218d93042d9ed65e67933389e8087d326fe4a65e21bcb22b08d2c3543de14L178

      Workaround

            jumperchen jumperchen
            MDuchemin MDuchemin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: