Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-5127

Review ZK preparedness for browser version with 3 digits (firefox, chrome, safari)

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Invalid
    • Icon: Normal Normal
    • None
    • None
    • None
    • None

      User Story

      Major browsers will jump their version to 100.

      There are concerns about web applications failing to parse these new versions, due to change of version string length. (think Y2K bug, but for browser versions).

       

      Manual testing of the following versions did not show bugs:

      • 9.6.1
      • 9.6.0
      • 8.6.0
      • 7.0.3
      • 6.5.4

      Acceptance Criteria

      ZK applications do not encounter issues due to version parsing

      Details

      https://developer.chrome.com/blog/force-major-version-to-100/

      https://hacks.mozilla.org/2022/02/version-100-in-chrome-and-firefox/

       

      Tested by spoofing user-agent string using developer tools in chrome, with UA:

      Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4606.54 Safari/537.36

       

      User-Agent parsing at

      https://github.com/zkoss/zk/blob/bad38b3ea65122bb44586c9266db4e3cb66edbdc/zweb/src/org/zkoss/web/servlet/Servlets.java#L496-L512

       

      https://github.com/zkoss/zk/blob/bad38b3ea65122bb44586c9266db4e3cb66edbdc/zweb/src/org/zkoss/web/servlet/Servlets.java#L402

       

      possibly interfering with https://github.com/zkoss/zk/blob/27f90007e4d63638036b059da0ce2cd608b9b597/zk/src/org/zkoss/zk/device/Devices.java#L100 ?

       

            Unassigned Unassigned
            MDuchemin MDuchemin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: