Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-4712

closure-compiler.jar in binary download package conflicts with gson.jar

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 9.5.1
    • 9.5.0.1
    • General
    • Security Level: Jimmy
    • ZK 9.5.1 S1

      Steps to Reproduce

      unzip the jars provided in the binary download packages and compare jar versions

      Current Result

      • gson.jar 2.3.1
      • closure-compiler.jar v20200426
      • which contains gson classes of version 2.7

      Expected Result

      A) only one implementation version of gson to avoid class loading/version conflicts
      or
      B) remove the optional closure compiler completely or into a subfolder it's an optional dependency
      or
      C) use closure-compiler-unshaded.jar and eliminate jar conflicts before bundling the download packages

      Debug Information

      the maven dependencies use the closure-compiler-unshaded.jar to avoid duplicate dependencies

      Workaround

      RECOMMENDED: use a dependency management tool such as maven or gradle

      (if maven/gradle are not available): don't add (the optional) closure-compiler.jar to a project

            rudyhuang rudyhuang
            cor3000 cor3000
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 4 hours Original Estimate - 4 hours
                4h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours
                5h