Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-4514

AuUploader and AuDropUploader exceptions are suppressed, need logging

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 9.0.1
    • Fix Version/s: 9.5.0
    • Component/s: None
    • Security Level: Jimmy
    • Labels:
      None
    • gh.sprint.customfield.default.name:
      ZK 9.5.0 S1

      Description

      Debug Information

      https://github.com/zkoss/zk/blob/ec559349801fcc31e7cd5b2ccea14714fc249479/zk/src/org/zkoss/zk/au/http/AuUploader.java#L442

      AuUploader and AuDropUloader use common fileupload to retrieve uploaded medias during parseRequest()

       

      If the common-upload library encounter an issue during sfu.parseRequest(request), it may throw a FileUploadException

      This exception is caught in the try catch block located in the service method

      https://github.com/zkoss/zk/blob/ec559349801fcc31e7cd5b2ccea14714fc249479/zk/src/org/zkoss/zk/au/http/AuUploader.java#L167-L193

       

      In the exception is caught in this block, there is no client alert, or logging available for FileUploadException (it doesn't trigger any of the existing exceptions)

       

      Improvement

      Add a special handling case for FileUploadException which logs to logger

       

        Attachments

          Activity

            People

            Assignee:
            rudyhuang rudyhuang
            Reporter:
            MDuchemin MDuchemin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 day
                1d
                Remaining:
                Time Spent - 4 hours Remaining Estimate - 4 hours
                4h
                Logged:
                Time Spent - 4 hours Remaining Estimate - 4 hours
                4h