Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-3783

panel/window close button markup/style inconsistent

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: Freshly, 8.5.0
    • Fix Version/s: 8.5.0
    • Component/s: Components
    • Security Level: Jimmy
    • Labels:
      None

      Description

      Steps to Reproduce

      run the attachment
      (optional: choosing atlantic theme makes it more obvious)
      all themes are affected

      Current Result

      Expected Result

      consistent markup/styling - same as in window component

      Debug Info

      this seems like an issue with the panel mold where the close button is rendered as a button, while all other window/panel buttons are rendered as div elements
      hence the styles don't match giving inconsistent results

      Root Cause

      https://github.com/zkoss/zk/blob/v8.0.5/zul/src/archive/web/js/zul/wnd/mold/panel.js#L29
      renders a <button>, while the other buttons are rendered as <div>

        Attachments

          Activity

            People

            Assignee:
            wenninghsu wenninghsu
            Reporter:
            cor3000 cor3000
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h