Uploaded image for project: 'Keikai'
  1. Keikai
  2. KEIKAI-574

avoid calling a heavy-cost method to log

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 5.9.0
    • Fix Version/s: 5.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Steps to Reproduce

      1. import a 50MB file and profile with VisaulVM sampler

      Current Result

      SheetRegion.getReferenceString() takes some time which is unexpected

      Expected Result

      SheetRegion.getReferenceString() should not be invoked by logger when log level is higher than DEBUG

      Debug Information

      • parameterized messages only save the cost of calling toString(). the logger stills call a new statement or other methods before creating a logger message.
      • should pass a variable instead of calling a method.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jumperchen jumperchen
              Reporter:
              hawk hawk
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: