Uploaded image for project: 'Keikai'
  1. Keikai
  2. KEIKAI-420

improve double converting by a pre-compiled regular expression

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Normal
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.7.0
    • Component/s: None
    • Labels:
      None

      Description

      Current Result

      org.zkoss.poi.ss.formula.eval.OperandResolver.fpRegex will be used for many times when converting a string to a double in a formula.

      Proposed improvement

      As Pattern javadoc recommends:

      If a pattern is to be used multiple times, compiling it once and reusing it will be more efficient than invoking this method each time.

      We should use a compiled one.

        Attachments

          Activity

            People

            Assignee:
            henrichen henrichen
            Reporter:
            hawk hawk
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: