Uploaded image for project: 'Keikai'
  1. Keikai
  2. KEIKAI-163

Refactor Spreadsheet.java


    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Normal Normal
    • 5.1.0
    • None
    • None
    • Security Level: Jimmy
    • None

      Current Result

      The current implementation of Spreadsheet.java contains too many code about 7K lines, which is hard to maintain and modify. 

      Expected Result

      • Simplify and refactor Spreadsheet.java
      • extract those code for rendering to client to a separate package e.g. Spreadsheet::getCellAttr
      • https://github.com/zkoss/keikaicml/blob/master/keikai/src/io/keikai/api/Books.java#L13 BOOK_TYPE_KEY is declared in 3 different places: Books, AbstractImporter, AbstractExcelImporter. It's better to reduce to 1.
      • suggest to collect all server-to-client commands constants into one class e.g. smartUpdate("activeRange", activeRange); renderer.render("toolbarButtons", _buttons), so that we can easily reviews/checks these commands.

        There are no Sub-Tasks for this issue.

            jumperchen jumperchen
            jumperchen jumperchen
            0 Vote for this issue
            1 Start watching this issue