Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-3895

wrong implementation in the widget function zul.tab.Tabbox.isRight()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 8.5.1
    • Fix Version/s: 8.5.2
    • Component/s: None
    • Security Level: Jimmy
    • Labels:
      None
    • gh.sprint.customfield.default.name:
      ZK 8.5.2 S1, ZK 8.5.2 S2

      Description

      Steps to Reproduce

      in Tabbox.js

      	/**
      	 * Returns whether it is the right orientation.
      	 * @return boolean
      	 */
      	isRight: function () {
      		var orient = this.getOrient();
      		return 'vertical' == orient || 'left' == orient;
      	},
      	/**
      	 * Returns whether it is the left orientation.
      	 * @return boolean
      	 */
      	isLeft: function () {
      		return 'left' == this.getOrient();
      	},
      

      in Tabbox.java

      	/**
      	 * Returns whether it is the left orientation.
      	 *
      	 * @since 7.0.0
      	 */
      	public boolean isLeft() {
      		String orient = getOrient();
      		return "vertical".equals(orient) || "left".equals(orient);
      	}
      
      	/**
      	 * Returns whether it is the right orientation.
      	 *
      	 * @since 7.0.0
      	 */
      	public boolean isRight() {
      		return "right".equals(getOrient());
      	}
      

      Current Result

      In js isRight() function, it checks left which is wrong and its implementation looks similar to Java's isLeft(). It could be misplaced.

      Expected Result

      consistency

        Activity

        Hide
        Anonymous added a comment -

        Fixed since 2018/06/29

        Show
        Anonymous added a comment - Fixed since 2018/06/29

          People

          • Assignee:
            wenninghsu wenninghsu
            Reporter:
            hawk hawk
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile