Uploaded image for project: 'ZK'
  1. ZK
  2. ZK-2692

SLF4J logging argument syntax

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • 7.0.6
    • 7.0.5
    • Components
    • Security Level: Jimmy

      some parameterized logging messages in ZK are using a wrong parameter syntax making the logging output pointless in some cases
      e.g.
      https://github.com/zkoss/zk/blob/master/zkbind/src/org/zkoss/bind/impl/BinderImpl.java#L354

      _log.debug("doPropertyChange:base=[%s],prop=[%s]",base,prop);

      the SLF4j docs explain that '{}' are used for parameterized messages instead of '%s'
      http://www.slf4j.org/apidocs/org/slf4j/Logger.html

      Likely other classes are affected too after the change to slf4j.

            jumperchen jumperchen
            cor3000 cor3000
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m